First off, it's a victory for the opposition, in the sense that MP's will view the detainee documents in their uncensored form. This deal is also a victory for Parliamentary supremacy, in the most general sense. BUT, in reality, there is still much to be determined, and given past government stalling tactics, nobody should see today's agreement as a conclusion- in fact, this is just the beginning of a long, contentious process.
The gigantic unknown, what exactly will be the composition of this "panel of arbitrators". It seems fair to believe the government MP will fight tooth and nail, which means any agreement within the MP review is unlikely. This assumption dictates that almost every sentence will move to this panel of jurists, and they will have final say, their verdict CAN'T be appealed. I note Nicholson has already stated that the redacted portions have already been reviewed by a third party, and he seemed quietly confident that much will remain hidden.
I see stalling tactics, no true resolution for months and months. In fact, this process doesn't even begin until this Parliamentary session is almost over, then we have summer break, leaving the real debate until the fall. If you believe an election is probable by the next budget, it's entirely reasonable to suggest the government has effectively buried this issue until after the next vote. It's for this reason, that I find it hard to get terribly excited about this agreement- and it also helps to explain why the government agreed.
In essence, while the opposition MP's have won the right to view, they are still under the control of a panel, which will have a subjective component. WHO these people are is paramount. For example, Iacobucci has a paper trail on these issues, and has shown himself to be sympathetic to redactions. It's imperative that we have full public disclosure of the "candidates" prior to their appointment, so we can be sure of impartiality. There is a great unknown here, and for that reason nobody can say anything with certainty.
The sheer mass of material, coupled with entirely available stall tactics for the government MP, mean that in the short term, the government is satisfied. We may get to the truth here, but one wonders if the delays will succeed in distracting, or that any political price will be paid. The opposition didn't sell out, certain rights confirmed, but the more I think about this deal, the more it tells me that nothing is settled.